Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute urls in local editor links #11

Closed
wants to merge 1 commit into from

Conversation

glanzel
Copy link

@glanzel glanzel commented Feb 19, 2021

This commit solves the Issue #8
It changes only the urls of links created in the birdsong editor
all other Richt Text Field Links are left untouched.

I hope that could be a useful approach for the Issue.

@glanzel glanzel marked this pull request as ready for review February 19, 2021 17:29
@seb-b
Copy link
Member

seb-b commented Apr 21, 2021

Sorry missed this when it was first opened.

This looks good, I hadn't seen register_temporarily before. Looks like it was introduced in wt 2.10 so we'll have to up the minimum version.
I cloned this branch and gave it a go, but my link added was still relative, was this working for you?
image

@glanzel
Copy link
Author

glanzel commented Apr 25, 2021

Hi I just tested it again. Still works for me.
I use it like that:
`class ACampaign(Campaign):
body = StreamField(DefaultBlocks())

panels = Campaign.panels + [
    StreamFieldPanel('body'),
]`

When i use PageLinks or DocumentsLinks in the DefaultBlocks Editor the Preview already shows an absolute path for me.

@seb-b seb-b closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants