Implement ATs with JST and enable incremental compilation #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: a04871c7da83dcec4f6ed4901af0d48384459820. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #147' // https://github.com/neoforged/NeoGradle/pull/147
url 'https://prmaven.neoforged.net/NeoGradle/pr147'
content {
includeModule('net.neoforged.gradle', 'common')
includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-common')
includeModule('net.neoforged.gradle', 'dsl-mixin')
includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-userdev')
includeModule('net.neoforged.gradle', 'userdev')
includeModule('net.neoforged.gradle', 'platform')
includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
includeModule('net.neoforged.gradle', 'neoform')
includeModule('net.neoforged.gradle', 'dsl-neoform')
includeModule('net.neoforged.gradle', 'dsl-vanilla')
includeModule('net.neoforged.gradle', 'dsl-platform')
includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
includeModule('net.neoforged.gradle', 'utils')
includeModule('net.neoforged.gradle', 'vanilla')
includeModule('net.neoforged.gradle', 'mixin')
includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
}
}
} |
lukebemish
suggested changes
Apr 18, 2024
| } | ||
|
|
||
| @TaskAction | ||
| public void doTask() throws IOException { |
There was a problem hiding this comment.
This feels like something to just use FileSystemOperations and a copy spec for instead of manually traversing stuff
marchermans
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply ATs on the source and not on the pre-decomp jar, to allow AT changes to be applied quicker, by not involving decompilation again.
To incrementally compile, the task should only detect changes in files on disk. To achieve this, the sources are unpacked before compilation, in such a way that files aren't overwritten unless they need to be, as timestamps play a role in verifying whether a file change should be ignored.
This PR also makes the list libraries task deterministic.