Skip to content

Commit

Permalink
Fix unused mcp_mappings placeholder causing problems (#153)
Browse files Browse the repository at this point in the history
Previously we set the unused mcp_mappings placeholder to a file that doesn't exist. Gradle now checks the file we try to resolve actually exists and crashes.
  • Loading branch information
shartte authored Apr 27, 2024
1 parent 1bc3f8b commit a535ef3
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ public Map<String, String> buildRunInterpolationData(RunImpl run) {
final Map<String, String> interpolationData = new HashMap<>(super.buildRunInterpolationData(run));

interpolationData.put("mcp_version", neoform.getVersion());
interpolationData.put("mcp_mappings", getSpecification().getNeoFormArchive()
.matching(artifact -> artifact.include("config/joined.srg"))
.getSingleFile().getAbsolutePath());
// NeoForge still references this in the environment variable MCP_MAPPINGS, which is unused since 1.20.2
// Remove this interpolation placeholder once NeoForge removes the environment variable from its config.json
interpolationData.put("mcp_mappings", "UNUSED_DEPRECATED");
return interpolationData;
}

Expand Down

0 comments on commit a535ef3

Please sign in to comment.