Close output stream after writing files in CopyingFileTreeVisitor (#128)

neoforged · Mar 9, 2024 · 2878f69 · 2878f69
1 parent 2467789
commit 2878f69
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/utils/src/main/java/net/neoforged/gradle/util/CopyingFileTreeVisitor.java b/utils/src/main/java/net/neoforged/gradle/util/CopyingFileTreeVisitor.java
@@ -6,13 +6,9 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.io.OutputStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.List;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 public class CopyingFileTreeVisitor implements FileVisitor {
 
@@ -85,7 +81,11 @@ public void visitFile(FileVisitDetails fileDetails) {
         final Path target = directory.resolve(fileDetails.getRelativePath().getPathString());
         try {
             Files.createDirectories(target.getParent());
-            fileDetails.copyTo(Files.newOutputStream(target));
+        } catch (IOException e) {
+            throw new RuntimeException("Could not create parent directories for: " + target, e);
+        }
+        try (OutputStream out = Files.newOutputStream(target)) {
+            fileDetails.copyTo(out);
         } catch (IOException e) {
             throw new RuntimeException("Could not create file: " + target, e);
         }