-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ReferenceCounter
to an interface
#3524
Conversation
What do you think @neo-project/core ? if we push an item, we call Add, if we pop a item, we call remove, same for Compound items, and when a pop is done in a compound item, we call Remove also. In this way, we have a better system, the worst, two same stack items, will be counted as two, but we will be faster, and we can increase the limmit sample b50ab91 |
ReferenceCounter
to an interface
but pop and push are very classical name for operations on stack~~~~ BTW, how about name the referencecounter as something like referencecounter with GC, or GC referencecounter,,,, |
Sure, @shargon Let me discuss this internally here and soon reply with more ideas. Next Monday at least before merging this one. |
It's very nice to have a clear interface on ReferenceCounter. Congratulations @shargon . |
Description
First step of #3517
ReferenceCounter
to an interfaceType of change
How Has This Been Tested?
Test Configuration:
Checklist: