Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New link on studio home to Taxonomy list #23

Merged
merged 2 commits into from
May 15, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented May 7, 2024

Description

This is a backport of openedx#33439

Testing instructions

The provided instructions on the original pr are enough, just consider that you can use the branch master of course-authoring and if you are using a cms custom theme, you should update that

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template is loading, but seems redirecting to a not good url.

if use_tagging_taxonomy_list_page():
mfe_base_url = settings.COURSE_AUTHORING_MICROFRONTEND_URL
if mfe_base_url:
taxonomy_list_url = f'{mfe_base_url}/taxonomy-list'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that course-authoring in master now doesn't have that route.
Peek 2024-05-08 17-47

Copy link
Collaborator Author

@andrey-canon andrey-canon May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right they removed that two weeks ago openedx/frontend-app-authoring#954

@andrey-canon andrey-canon force-pushed the and/backport_taxonomy_tab branch 2 times, most recently from 3898b92 to ac06e18 Compare May 9, 2024 23:35
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working =)
Peek 2024-05-10 16-36

@andrey-canon andrey-canon changed the base branch from and/backport_home_api to open-release/palm.nelp May 14, 2024 19:20
@andrey-canon andrey-canon merged commit 7696b70 into open-release/palm.nelp May 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants