fix: test only accepts int values in priority #12
Conversation
johanseto
force-pushed
the
jlc/fix-statics-tabs-tests
branch
from
a30da94
to
879ad70
Compare
This test https://github.com/openedx/edx-platform/blob/open-release/palm.master/cms/djangoapps/contentstore/rest_api/v0/tests/test_tabs.py#L108 dont accept None value in a list sort function. So as this is order ascending, a big value gives the same beahviour Also progress would be first than dates.
johanseto
force-pushed
the
jlc/fix-statics-tabs-tests
branch
2 times, most recently
from
a25cdf0
to
942671c
Compare
now dates is the last element of ithe list and progress is always before dates.(penultimate)
johanseto
force-pushed
the
jlc/fix-statics-tabs-tests
branch
from
942671c
to
61816d5
Compare
|
The commit 61816d5 fixes the deletion of the progress tab because now is at the end of the list. |
The function validate_args https://github.com/openedx/edx-platform/blob/open-release/palm.master/cms/djangoapps/contentstore/views/tabs.py#L233 only allow num >=1
johanseto
force-pushed
the
jlc/fix-statics-tabs-tests
branch
from
5ccf60c
to
6109a1c
Compare
There was a problem hiding this comment.
As this pr mentioned these changes were required to fix the tabs sorting however the pr#2 doesn't make that, that just moves at the end the wiki, progress and syllabus tabs but it's not possible to change the order of the tabs
maple e.g
palm without mfe
the mfe version is more limited
Basically that functionality was removed in this pr when they changed the is_movable attribute default value
So my advice is to close this pr, revert the pr #2 and include this change in this list since that sorting feature was deprecated and our changes doesn't cover the necessity that we had
According to that, this gonna be closed in favor of #13 |
Description
This fix is a test for this feature #2.
This test https://github.com/openedx/edx-platform/blob/open-release/palm.master/cms/djangoapps/contentstore/rest_api/v0/tests/test_tabs.py#L108 dont accept None value in a list sort function.
So as this is order ascending, a big value gives the same behavior
Testing instructions
Check the tabs and they continue ordering in the desired way as the proposed in this PR #2 .
Before
Tests was failing in static tabs.
https://github.com/nelc/edx-platform/actions/runs/7702081514/job/20990641623?pr=11
Other information
PRs related
#2
eduNEXT/edunext-platform#678
eduNEXT/edunext-platform#801