Skip to content

Commit

Permalink
feat: remove staff access for catalog views
Browse files Browse the repository at this point in the history
This is controversial, but simple. To do this in a monkey patch is a bigger task and also with
more work. Is different due the change is in a nested function. Anyway the alternative is to
monkeyPatch the _dispatch method and handle there. But its risky and also that method manage other permission with different ways.
  • Loading branch information
johanseto committed Sep 5, 2024
1 parent c6a6b05 commit 4f78c22
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lms/djangoapps/courseware/access.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ def can_see_in_catalog():
"""
return (
_has_catalog_visibility(courselike, CATALOG_VISIBILITY_CATALOG_AND_ABOUT)
or _has_staff_access_to_descriptor(user, courselike, courselike.id)
)

@function_trace('can_see_about_page')
Expand Down

0 comments on commit 4f78c22

Please sign in to comment.