remove transform style warning since the native alternative doesn't work for most cases. #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork for most cases.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 546b147:
|
|
Re: interpolation #2528 (comment) |
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Feb 1, 2024
…SSR (#26812) # Why It's too hard to make sense of the console logs that are executed in the server renderer. This PR aims to add more clarity. <img width="906" alt="Screenshot 2024-01-30 at 8 56 19 PM" src="https://github.com/expo/expo/assets/9664363/3ab0d3e5-9d71-4bc5-a7fe-3691472cc73d"> We'll now add the same log tagging as logs that come from native clients. However, we'll also add a lambda character to indicate that the log is from a server platform (we should do this disambiguation for every platform imo). If the log is of type warn or error, then we'll also show a formatted stack trace with hidden files removed unless `EXPO_DEBUG` is enabled. You can see from the screenshot above that the pesky warnings are coming from react navigation and safe area context. Every user will see these warnings in every project, so we should aim to resolve the warnings. - safe area context warning is fixed here th3rdwave/react-native-safe-area-context@e2c8027 - react navigation warnings fixed here necolas/react-native-web#2622 - error is just an example in the app source. In production, this will only show the last trace. --------- Co-authored-by: Expo Bot <[email protected]>
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Feb 1, 2024
…SSR (#26812) It's too hard to make sense of the console logs that are executed in the server renderer. This PR aims to add more clarity. <img width="906" alt="Screenshot 2024-01-30 at 8 56 19 PM" src="https://github.com/expo/expo/assets/9664363/3ab0d3e5-9d71-4bc5-a7fe-3691472cc73d"> We'll now add the same log tagging as logs that come from native clients. However, we'll also add a lambda character to indicate that the log is from a server platform (we should do this disambiguation for every platform imo). If the log is of type warn or error, then we'll also show a formatted stack trace with hidden files removed unless `EXPO_DEBUG` is enabled. You can see from the screenshot above that the pesky warnings are coming from react navigation and safe area context. Every user will see these warnings in every project, so we should aim to resolve the warnings. - safe area context warning is fixed here th3rdwave/react-native-safe-area-context@e2c8027 - react navigation warnings fixed here necolas/react-native-web#2622 - error is just an example in the app source. In production, this will only show the last trace. --------- Co-authored-by: Expo Bot <[email protected]>
gypaullin
pushed a commit
to Cofit/react-native-web
that referenced
this pull request
Jul 5, 2024
React Native's implementation of string transforms is incomplete. Close necolas#2622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string interpolation system doesn't appear to work with React Animated as the string would convert the animated object to
[Object object].