Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 compatible ingress checks #2496

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jorop
Copy link

@jorop jorop commented May 29, 2024

Reference Issues or PRs

Addresses #2485
For ipv6 working, at least an update of keycloak is also necessary.

What does this implement/fix?

Ingress checks will be successful on ipv6 also using getaddrinfo instead of gethostbyname.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@viniciusdc
Copy link
Contributor

Hi @jorop, thank you for your contribution! We're currently in the midst of a significant update focused on our RBACs and JupyterHub, which might cause some delays in addressing your input.

We discussed this in our internal sync yesterday, and I’d like to invite you to join our community sync meetings as well: https://www.nebari.dev/docs/community/#community-meetings. These meetings are open to everyone and provide a great platform for further discussion. Please note that this item is not yet on our roadmap because we are assessing the stability of specific components that support IPv6 exclusively, which would require some more thought into it...

In the meantime, for backward compatibility, it would be beneficial to include a custom field in the ingress section of the nebari-config.yaml file. This field would allow us to toggle between different implementations as needed.

@viniciusdc viniciusdc added the needs: follow-up 📫 Someone needs to get back to this issue or PR label Aug 1, 2024
@viniciusdc
Copy link
Contributor

@jorop I will be doing a check on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: follow-up 📫 Someone needs to get back to this issue or PR
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

2 participants