Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes for Nebari Integration #49

Merged
merged 31 commits into from
Jan 8, 2024
Merged

Misc fixes for Nebari Integration #49

merged 31 commits into from
Jan 8, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Jan 7, 2024

Reference Issues or PRs

Ref: nebari-dev/nebari#2011

  • Use forward slashes for the url
  • Rename JWT_SECRET_KEY to JHUB_APP_JWT_SECRET_KEY
  • Add endpoint to get services
  • Add more logging
  • Send in fake spawner object to config.KubeSpawner.profile_list
  • Add slug to profile list
  • Don't display services with service.info.name attribute

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@aktech aktech merged commit 7c666aa into main Jan 8, 2024
8 checks passed
@aktech aktech deleted the misc-fixes branch January 8, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant