Merge pull request #47 from nebari-dev/parameterize-hub-host

parameterize hub host
nebari-dev · Jan 6, 2024 · 9970b9e · 9970b9e
2 parents f4fd1e4 + 934f6a1
commit 9970b9e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/jhub_apps/config_utils.py b/jhub_apps/config_utils.py
@@ -38,3 +38,8 @@ class JAppsConfig(SingletonConfigurable):
         "jupyterhub_config.py",
         help="Path to JupyterHub config file.",
     ).tag(config=True)
+
+    hub_host = Unicode(
+        "127.0.0.1",
+        help="Hub Host name, in k8s environment it would be the container name, e.g. 'hub'",
+    ).tag(config=True)
diff --git a/jhub_apps/configuration.py b/jhub_apps/configuration.py
@@ -27,6 +27,9 @@ def install_jhub_apps(c, spawner_to_subclass):
     if not isinstance(c.JAppsConfig.app_icon, str):
         c.JAppsConfig.app_icon = JAppsConfig.app_icon.default_value
 
+    if not isinstance(c.JAppsConfig.hub_host, str):
+        c.JAppsConfig.hub_host = JAppsConfig.hub_host.default_value
+
     if not isinstance(c.JAppsConfig.jupyterhub_config_path, str):
         c.JAppsConfig.jupyterhub_config_path = (
             JAppsConfig.jupyterhub_config_path.default_value
@@ -45,7 +48,7 @@ def install_jhub_apps(c, spawner_to_subclass):
         [
             {
                 "name": fast_api_service_name,
-                "url": "http://127.0.0.1:10202",
+                "url": f"http://{c.JAppsConfig.hub_host}:10202",
                 "command": [
                     c.JAppsConfig.python_exec,
                     "-m",