Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#12 checkbox #23

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Feat/#12 checkbox #23

merged 11 commits into from
Oct 24, 2023

Conversation

Ademsk1
Copy link
Contributor

@Ademsk1 Ademsk1 commented Oct 24, 2023

Fixes #12

adds in Checkbox

  • Indeterminate
  • Ticked
  • Unticked

Here are the pictures
Screenshot 2023-10-24 at 13 45 07
Screenshot 2023-10-24 at 13 45 04
Screenshot 2023-10-24 at 13 45 00

Please feel free to consult the Figma board here to compare.

Ademsk1
Ademsk1 commented Oct 24, 2023
View reviewed changes
tailwind.config.js
Comment on lines +27 to 29
darkMode: 'class',
plugins: []
}
Copy link
Contributor Author

@Ademsk1 Ademsk1 Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ did not mean to change where darkMode was. Will address later.

ergusto
ergusto requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ergusto ergusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I wonder if we can make the icon generation part of the build process rather than commit the output of the command ourselves? Might be better to leave that as a future improvement though. One small change required then I can approve it.

stories/Checkbox/CheckBox.example.tsx Outdated Show resolved Hide resolved
@ergusto ergusto self-requested a review October 24, 2023 14:34
ergusto
ergusto requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ergusto ergusto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a thought, the demo for this component should probably also show a fully working example with state to allow checking/unchecking the checkbox, rather than just controlling the value through props.

@Ademsk1 Ademsk1 requested a review from ergusto October 24, 2023 15:44
@Ademsk1 Ademsk1 merged commit 94f6203 into main Oct 24, 2023
3 checks passed
@Ademsk1 Ademsk1 deleted the feat/#12_checkbox branch October 24, 2023 15:54
This was referenced Nov 3, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergusto ergusto ergusto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a Checkbox component
2 participants
@Ademsk1 @ergusto