test(staking): Unstake and restake node. Wait for it to sync #12247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12247 +/- ##
=======================================
Coverage 71.65% 71.66%
=======================================
Files 838 838
Lines 167441 167441
Branches 167441 167441
=======================================
+ Hits 119986 119989 +3
+ Misses 42222 42216 -6
- Partials 5233 5236 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@VanBarbascu: I am not sure who would be a good reviewer for this PR. As it is adding a new test, I am approving it. But if you need a more detailed review, please suggest someone.
VanBarbascu
force-pushed
the
statesync/staking
branch
from
5fd7cd2
to
bdeff4d
Compare
Thanks @akhi3030! This is part of the testnet release investigation. @marcelo-gonzalez , @saketh-are and @andrei-near are the target audience. |
| centralized_state_sync=False, | ||
| decentralized_state_sync=False): | ||
| (node_config_dump, | ||
| node_config_sync) = state_sync_lib.get_state_sync_configs_pair( |
There was a problem hiding this comment.
All of these tests are using the same config, one in which it is specified that an external source is available in state_part_dir. In 2.3.0-rc.4 we made it so that if an external source is configured, it will be used directly and no requests will be made to peers. Then in test_state_sync_with_restaking_decentralized_only you have the same config but you don't dump state parts in the state_part_dir. Hence the node just gets stuck looking for state parts in the external directory.
There was a problem hiding this comment.
Thanks for clarifying this! I assumed that we fallback from external to peers, but instead we do just external.
In this case, how are we going to test the DSS? DSS still relies on the external storage for state parts, but if you set the external configs, will only do cloud sync.
|
|
||
| self.testcase.wait_for_blocks(3) | ||
|
|
||
| self.testcase.create_accounts() |
There was a problem hiding this comment.
This part seems to be flaky, sometimes the test times out waiting for the result of the transactions which create the accounts.
If the expected sender is not specified, we should accept a response from any peer. We don't specify an expected sender for state parts, so this bug meant that state sync was ignoring all parts received from peers. #12247 adds tests which cover this code and detect this problem.
Run each test with the following command replacing the test case: