Replace tweetnacl by @noble/curves #1209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
This PR aims to replace tweetnacl with @noble/curves to improve the security of near-api-js. The reason is that tweetnacl has a problem called signature malleability. This means that someone could create a different signature for the same message without knowing the secret key. This could lead to vulnerabilities in certain situations. @noble/curves doesn't have this issue, making it a more secure choice for our cryptographic needs. Additionally, @noble/curves is much smaller than tweetnacl. It’s used in a lot of Ethereum projects including Metamask and protonmail, so it should be reliable replacement.
Test Plan
The existing keypair generation, signature generation and validation tests are passing.
Related issues/PRs
#1199