Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and tests by changing testnet node url and temporarily removing accounts tests #1207

Closed
wants to merge 2 commits into from

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Nov 22, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #1206) and the maintainers have approved on my working plan.

Motivation

This PR fixes CI actions allowing to reliably assert whether other changes are causing regressions. These changes are temporary and issues have been created.

Test Plan

Related issues/PRs

#1206

@gtsonevv gtsonevv requested a review from frol November 22, 2023 14:42
Copy link

changeset-bot bot commented Nov 22, 2023

⚠️ No Changeset found

Latest commit: cfde296

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtsonevv gtsonevv changed the title fix: change testnet node url; temporarily remove accounts tests Fix CI and tests by changing testnet node url and temporarily removing accounts tests Nov 22, 2023
@gagdiez
Copy link
Contributor

gagdiez commented Nov 27, 2023

This is actually very dangerous, since you are literally removing tests just to see the tests not fail. However, I see why this was done: the CI RPC node was down.

I would instead recommend you to ping @frol or me and ask for the ci node to be put back online.

I would directly close this PR to make sure nobody can merge it.

@gagdiez gagdiez closed this Nov 27, 2023
@frol
Copy link
Collaborator

frol commented Nov 27, 2023

@gtsonevv let’s use near-sandbox/near-workspaces to launch a local node instead of relying on an external node

@gtsonevv
Copy link
Collaborator Author

@frol sure, but what about the failing accounts tests?

@frol
Copy link
Collaborator

frol commented Nov 27, 2023

@gtsonevv Those needs to be fixed instead of disabled. It is not helpful to mask the test errors, we may as well just keep merging PRs with failing CI - at least this would be a conscious action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework 'accounts' package tests due to removal of top-level account creation functionality
3 participants