Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix and improvements on biometric-ed25519 package #1148

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

hcho112
Copy link
Contributor

@hcho112 hcho112 commented Jun 21, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This PR contains fixes and improvements for fido2 part of biometric-ed25519.

Test Plan

I have manually tested above change within near-discovery + using android studio on mac environment to simulate the android experience.

Related issues/PRs

N/A

@hcho112 hcho112 requested a review from andy-haynes June 21, 2023 04:26
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

🦋 Changeset detected

Latest commit: 60b5904

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@near-js/biometric-ed25519 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hcho112 hcho112 changed the title Fast 120 Bugfix and improvements on biometric-ed25519 package Jun 21, 2023
Copy link
Collaborator

@andy-haynes andy-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Danny ❤️

@andy-haynes andy-haynes merged commit a1e8018 into master Jun 21, 2023
1 check passed
@andy-haynes andy-haynes deleted the FAST-120 branch June 21, 2023 18:00
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants