-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GoKibitz buildable again #186
base: master
Are you sure you want to change the base?
Conversation
memwatch-next is no longer supported and doesn't work under Node 10.16.0 (see [this issue](andywer/leakage#26)). Luckily it's not actually used for anything except a commented-out block of code. So removing the dependency doesn't break anything at all.
Again, the latest LTS NodeJS release isn't supported by node-sass <= 4.9 as can be [seen here](https://github.com/sass/node-sass#readme).
I feel equal measures of gratitude and guilt for seeing someone else put part of their lives into a chore that I have put off myself. Thanks! I'd be happy to jump in and provide assistance if you'd be willing to give me permission to contribute to your branch while it's in PR status.
.form-control {
background: {
color: $flat-green-sea;
}
$width: 3px;
border: {
color: $flat-green-sea;
radius: 0;
// (...and so on) |
My pleasure 😃 You should already have commit access to this branch specifically - let me know if it's not working for some reason and I can just make you a contributor on my entire fork.
|
The README updates are fantastic; thank you! I tried pushing to your branch and got an error--I think you have to manually allow me to make contributions, as described here. That's only if you'd like me to help you this way--if you'd rather collaborate by just having me make suggestions here, that's fine, too. |
I'm attempting to build a development version of GoKibitz and finding that it's incompatible in a few ways with NodeJS 10.16.0 LTS. This PR attempts to make the smallest number of changes needed to allow GoKibitz to run cleanly with a modern Node toolchain.
This PR is not ready for merging, I'm just opening now to hopefully get some help overcoming a few hurdles.
memwatch-next
andheapdump
dependenciesmemwatch-next is no longer supported and doesn't work under Node 10.16.0 (see this issue). Luckily it's not actually used for anything except a commented-out block of code. So removing the dependency doesn't break anything at all.
Again, the latest LTS NodeJS release isn't supported by
node-sass<=4.9
as can be seen here.I wanna wrap the tricky native dependencies and running a persistent mongo instance behind Docker to make it easy to run on any system without messing with nvm and junk. The NodeJS toolchain is really atrocious...
After getting a successful build,
gulp default
fails with:utf-8-validate
module dependencyAt the moment, any
npm build
will contain a failure of the form:README
about the correct format for.amazon-ses.js
, or provide a way to mock/ignore them.At the moment,
user.js
fails to run without it.I expect more problems to pop up after I get past the error above, but hopefully it can all be worked through 😃