-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement controller profiles for emulated controllers and a few QOL options #302
base: develop
Are you sure you want to change the base?
Conversation
…erentiating between button down and held
…econnect function
…ware version, serial number etc
…ame to substitute
…o match observations from official controllers
…nintentionally entering menus
…ts for (grey) joycon
…liser to avoid compiler warnings
mc_mitm/config.ini
Outdated
[misc] | ||
; Disable the LED lightbar on Sony Dualshock 4 and Dualsense controllers [default false] | ||
;disable_sony_leds=false | ||
[general] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general settings should probably be at the top of the file
m_colours.body = config.colours.body; | ||
m_colours.buttons = config.colours.buttons; | ||
m_colours.left_grip = config.colours.left_grip; | ||
m_colours.right_grip = config.colours.right_grip; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either align all these or leave only a single space around the =
11c2937
to
2bec6c2
Compare
e5720c0
to
d835ee2
Compare
a54904f
to
21feb40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool functions, I Wish to know ho to program at that level 8-D
…ini and update references
…al kill switch to disable profiles entirely
…rom system remapping
…etting for brightness level
67deadf
to
b35000b
Compare
What is the status on merging this? I have never been a friend of the Nintendo button layout, and the built-in remapping system is frustrating to use as it prompts every time I start if I actually want to keep the mappings I've made. Would rather just setup my Xbox Elite Series 2 controller with the Switch and have MissionControl keep A->physical A, X->physical X, etc. |
@abjugard it's kind of on hold for the moment for a couple of reasons. Firstly, I would like to release it alongside a nice GUI to make toggling and setting this stuff at runtime a breeze. I've made a start on both an applet and a Tesla overlay, but both of those require a bunch more work. The other issue is more a a design one. I am still a bit undecided about how controller profiles should work. Should each controller have its own settings page? Should profiles be more of a generic concept that can be loaded and saved and applied to controllers at will? Should settings persist through reboots? How to uniquely identify a USB controller (in a future release) in order to apply its profile, etc etc. None of these are problems I can't solve, but the decisions need to be made before committing to writing the GUI properly, and I haven't had enough time for either of those lately. My top priority for now is getting Bluetooth LE working. I see this involving a bit of refactoring of the controller classes. After this I think it might become a bit more clear how to proceed with this. If you find the inbuilt remapping too much of a pain in the arse (this is also something I am thinking about addressing), for now I might suggest you just modify the source to set the default mapping as you please and build it for yourself. See MissionControl/mc_mitm/source/controllers/xbox_one_controller.cpp Lines 113 to 116 in b076bc2
|
Makes a lot of sense. If you're interested in opinions on the questions posed; settings should definitely persist across reboots, and I think that it makes the most sense for settings to apply to one specific controller. Does USB controllers not advertise some ID that can be used for that? I don't think a Tesla overlay is really necessary if you build an app, will people need to change these settings from in-game? It might be cool depending on the type of settings available I guess. In general I'm actually a bit surprised there hasn't been a generic pluggable settings app written for Atmosphere and associated modules at this point. |
To do in the future: Use an actual stringifier for profiles values instead of copy pasting the default.
This should take care of #87, #43, and could lead to fixing #34 and #22.