Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Key Benefits page #666

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

Steph-Chong
Copy link
Collaborator

Resolves #569

@tennlee thinks the changes are okay

@nicholasloveday can you please review?

@Steph-Chong Steph-Chong changed the title Update Key Benefits page (Ready for review) Update Key Benefits page Sep 10, 2024
@tennlee
Copy link
Collaborator

tennlee commented Sep 10, 2024

I have merged this into https://scores.readthedocs.io/en/228-documentation-testing-branch/key_features.html (along with changes to the README).

docs/key_features.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nicholasloveday nicholasloveday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates - I'm happy with these changes (including your suggested change in the comments)

docs/key_features.md Show resolved Hide resolved
docs/key_features.md Outdated Show resolved Hide resolved
@Steph-Chong Steph-Chong changed the title (Ready for review) Update Key Benefits page Update Key Benefits page Sep 11, 2024
@tennlee tennlee merged commit ad55878 into nci:develop Sep 11, 2024
5 checks passed
@Steph-Chong Steph-Chong deleted the Update-Key-Features-page branch September 11, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Features page in docs - follow up questions
3 participants