-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update continuous and categorical sections of table in README #665
Update continuous and categorical sections of table in README #665
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
I have now udpated this PR following offline feedback from Tennessee. I also took the opportunity to make one minor edit in each of the three paragraphs following the table. My remaining questions are:
|
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
I have pushed this to 228, so it should render on readthedocs shortly |
https://scores.readthedocs.io/en/228-documentation-testing-branch/ Ping @nicholasloveday what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this update.
Signed-off-by: Stephanie Chong <[email protected]>
Signed-off-by: Stephanie Chong <[email protected]>
Fixes #647 - using @nicholasloveday's suggestions
Reduces the length of the continuous and categorical sections.
I think it looked okay in GitHub on my fork and looked okay in readthedocs when I built it locally.