-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added percent bias score (pbias) #639
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Hi @durgals I think we have checked this pretty thoroughly now. Please go ahead and make the requested changes, and then I'll give it another review at that point. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I see you have made some updates. Does that address everything so far? I wasn't sure whether to wait for more or whether that completes the update. Feel free to go through and respond to or resolve the messages on GitHub where they have now been dealt with. If those updates address everything, I'll go through and do a final check to see if this can now be merged. |
@durgals can you please also add yourself to the .zenodo.json file if you would like to be recognised as an author in Zenodo. (edit - adding some more info on how to do this) We recently starting archiving If so, please add your details at the bottom of the “creators” section in the .zenodo.json. The fields you will need to complete are:
|
I have updated addressing most or all of the above comments. |
Thanks. I will update .zenodo.json and commit with any other changes after final review. |
@durgals This all looks great to me! I have gone ahead and merged the PR. Great job, and thanks for doing high-quality work! Can you please raise a new PR to add yourself to the .zenodo.json file (don't try to resurrect this one or re-use this branch, that won't work smoothly) |
Please work through the following checklists. Delete anything that isn't relevant.
Development for new xarray-based metrics
reduce_dims
,preserve_dims
, andweights
args.Testing of new xarray-based metrics
xr.Dataarrays
andxr.Datasets
Tutorial notebook
Documentation