Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick updates to paper #398

Merged
merged 9 commits into from
May 19, 2024
Merged

Nick updates to paper #398

merged 9 commits into from
May 19, 2024

Conversation

nicholasloveday
Copy link
Collaborator

Here are a bunch of suggested changes. I have addressed some of the suggestions from @Steph-Chong in #53

Copy link
Collaborator

@Steph-Chong Steph-Chong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes.

I have provided a few thoughts for consideration (and also two things I hadn't noticed in previous rounds of feedback).

docs/paper.md Outdated Show resolved Hide resolved
docs/paper.md Outdated Show resolved Hide resolved
docs/paper.md Outdated Show resolved Hide resolved
docs/paper.md Outdated Show resolved Hide resolved
Co-authored-by: Stephanie Chong <[email protected]>
Signed-off-by: Nicholas Loveday <[email protected]>
docs/paper.md Outdated Show resolved Hide resolved
@nicholasloveday
Copy link
Collaborator Author

Thanks @Steph-Chong - I added your suggested changes which all make sense to me. I'll have a think about rephrasing the paragraph about jive and scores

@Steph-Chong
Copy link
Collaborator

Thanks @Steph-Chong - I added your suggested changes which all make sense to me. I'll have a think about rephrasing the paragraph about jive and scores

Re. that paragraph about Jive and scores - I really don't have a strong opinion. I like the initial version, I like your version, I don't hate my version. As long as it is clear and everyone is happy, that's fine by me :-).

@Steph-Chong
Copy link
Collaborator

Steph-Chong commented May 17, 2024

Not sure if these questions/comments should go here, or should go in PR #53 . Happy to relocate them to #53

  • Table: I think some of the scores have an authoritative reference, but the reference is not yet in the table. (When I pasted in the table, I added the references that were in the then previous version of the paper, but many new scores had been added between those paper versions, and I didn't go and add in the extra references).

  • Should more binary categorical scores be added, or are you happy with what is in the table? (I have no opinion on this).

  • Are references needed for any/all of: Jupyter Notebook, Python, GitHub, Dask, pandas, geopandas, NetCDF4, hdf5, Zarr and GRIB?

@nicholasloveday
Copy link
Collaborator Author

Not sure if these questions/comments should go here, or should go in PR #53 . Happy to relocate them to #53

Let's put these in another pull request as I won't have time to work on this for another week.

  • Table: I think some of the scores have an authoritative reference, but the reference is not yet in the table (e.g Brier Score). (When I pasted in the table, I added the references that were in the then previous version of the paper, but many new scores had been added between those paper versions, and I didn't go and add in the extra references).

Yes I did wonder that. We probably should. The Brier score reference is

@Article{BRIER_1950, title={VERIFICATION OF FORECASTS EXPRESSED IN TERMS OF PROBABILITY}, volume={78}, ISSN={1520-0493}, url={http://dx.doi.org/10.1175/1520-0493(1950)078<0001:vofeit>2.0.co;2}, DOI={10.1175/1520-0493(1950)078<0001:vofeit>2.0.co;2}, number={1}, journal={Monthly Weather Review}, publisher={American Meteorological Society}, author={BRIER, GLENN W.}, year={1950}, month=jan, pages={1–3} }

For the rest, if we are unsure, we can refer to the references in A Practitioner's Guide in Atmospheric Science, 2nd Edition. It's available online to all BoM staff.

  • Should more binary categorical scores be added, or are you happy with what is in the table? (I have no opinion on this).

I am happy if we just use one name when we have multiple implementations of the same thing under different names. We should check if any are missing.

  • Are references needed for any/all of: Jupyter Notebook, Python, GitHub, Dask, pandas, geopandas, NetCDF4, hdf5, Zarr and GRIB?
    Probably only pandas, geopandas, and dask.

@software{reback2020pandas,
author = {The pandas development team},
title = {pandas-dev/pandas: Pandas},
month = feb,
year = 2020,
publisher = {Zenodo},
version = {latest},
doi = {10.5281/zenodo.3509134},
url = {https://doi.org/10.5281/zenodo.3509134}
}

@software{kelsey_jordahl_2020_3946761,
author = {Kelsey Jordahl and
Joris Van den Bossche and
Martin Fleischmann and
Jacob Wasserman and
James McBride and
Jeffrey Gerard and
Jeff Tratner and
Matthew Perry and
Adrian Garcia Badaracco and
Carson Farmer and
Geir Arne Hjelle and
Alan D. Snow and
Micah Cochran and
Sean Gillies and
Lucas Culbertson and
Matt Bartos and
Nick Eubank and
maxalbert and
Aleksey Bilogur and
Sergio Rey and
Christopher Ren and
Dani Arribas-Bel and
Leah Wasser and
Levi John Wolf and
Martin Journois and
Joshua Wilson and
Adam Greenhall and
Chris Holdgraf and
Filipe and
François Leblanc},
title = {geopandas/geopandas: v0.8.1},
month = jul,
year = 2020,
publisher = {Zenodo},
version = {v0.8.1},
doi = {10.5281/zenodo.3946761},
url = {https://doi.org/10.5281/zenodo.3946761}
}

@Manual{,
title = {Dask: Library for dynamic task scheduling},
author = {{Dask Development Team}},
year = {2016},
url = {http://dask.pydata.org},
}

Co-authored-by: Stephanie Chong <[email protected]>
Signed-off-by: Tennessee Leeuwenburg <[email protected]>
@tennlee
Copy link
Collaborator

tennlee commented May 19, 2024

I am merging these changes. Please go ahead and add the comments / changes regarding citations to new PRs against branch 51.

@tennlee tennlee merged commit a2a8477 into 51-joss-paper-draft May 19, 2024
5 checks passed
@tennlee tennlee deleted the nick_updates_to_paper branch May 22, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants