-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nick updates to paper #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes.
I have provided a few thoughts for consideration (and also two things I hadn't noticed in previous rounds of feedback).
Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: Nicholas Loveday <[email protected]>
Thanks @Steph-Chong - I added your suggested changes which all make sense to me. I'll have a think about rephrasing the paragraph about jive and scores |
Re. that paragraph about Jive and scores - I really don't have a strong opinion. I like the initial version, I like your version, I don't hate my version. As long as it is clear and everyone is happy, that's fine by me :-). |
Not sure if these questions/comments should go here, or should go in PR #53 . Happy to relocate them to #53
|
Let's put these in another pull request as I won't have time to work on this for another week.
Yes I did wonder that. We probably should. The Brier score reference is @Article{BRIER_1950, title={VERIFICATION OF FORECASTS EXPRESSED IN TERMS OF PROBABILITY}, volume={78}, ISSN={1520-0493}, url={http://dx.doi.org/10.1175/1520-0493(1950)078<0001:vofeit>2.0.co;2}, DOI={10.1175/1520-0493(1950)078<0001:vofeit>2.0.co;2}, number={1}, journal={Monthly Weather Review}, publisher={American Meteorological Society}, author={BRIER, GLENN W.}, year={1950}, month=jan, pages={1–3} } For the rest, if we are unsure, we can refer to the references in A Practitioner's Guide in Atmospheric Science, 2nd Edition. It's available online to all BoM staff.
I am happy if we just use one name when we have multiple implementations of the same thing under different names. We should check if any are missing.
@software{reback2020pandas, @software{kelsey_jordahl_2020_3946761, @Manual{, |
Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: Tennessee Leeuwenburg <[email protected]>
I am merging these changes. Please go ahead and add the comments / changes regarding citations to new PRs against branch 51. |
Here are a bunch of suggested changes. I have addressed some of the suggestions from @Steph-Chong in #53