Post QS2 audit updates #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: ensure token symbol is unique * fix: some typos and comments * fix: entity token uniqueness mapping and add test * fix: include external tokens in uniqueness check * test: LibERC token symbol * feat: update entity token info * doc: update generated markdown * test: entity token info update * Revert "doc: update generated markdown" This reverts commit 96ed7ee. # Conflicts: # docs/facets/IEntityFacet.md * fix: linter issues * test: failed ERC20 calls * refactor: fix solidity parser in prettier
# Conflicts: # .env.example # Makefile # deployedAddresses.json # package.json # src/diamonds/nayms/AppStorage.sol # src/diamonds/nayms/libs/LibAdmin.sol # src/diamonds/nayms/libs/LibObject.sol # test/T01SmartDeploymentV1.t.sol.deleteme # test/T04Entity.t.sol # test/defaults/D03ProtocolDefaults.sol
* chore: ignore slither vscode files * feat: scripted scheduling * fix: update anvil bootstrap script * refactor: deployment on anvil, makefile * fix: makefile defaults and addresses * fix: anvil bootstrap * fix: anvil upgrade targets * chore: add sepolia broadcasts * chore: update sepolia broadcasts --------- Co-authored-by: Kevin Park <[email protected]>
# Conflicts: # Makefile
…eploy state updating contract
kevin-fruitful
approved these changes
Oct 2, 2023
| export MAINNET=1 | ||
| export SEPOLIA=11155111 | ||
| export LOCAL=123 | ||
| export LOCAL_ID=123 |
There was a problem hiding this comment.
local should be 31337. ID 123 is for some network called fuse sparknet: https://chainlist.org/chain/123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few issues have been resolved since the last audit and need to be deployed on
mainnet:SimplePolicyInfostruct #68