Returnere detaljer fra simuleringsfeil (#252)

* Returnere detaljer fra simuleringsfeil * Ikke logg sensitivt
navikt · Apr 24, 2024 · 1d09cfb · 1d09cfb
1 parent ca50487
commit 1d09cfb
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 3 deletions.
diff --git a/apps/etterlatte-proxy/src/main/kotlin/config/SimuleringOppdragConfig.kt b/apps/etterlatte-proxy/src/main/kotlin/config/SimuleringOppdragConfig.kt
@@ -22,8 +22,10 @@ class SimuleringOppdragConfig(config: Config, private val enableLogging: Boolean
         val enabledFeatures = mutableListOf<Feature>().apply {
             add(WSAddressingFeature())
             if (enableLogging) add(LoggingFeature().apply {
+                setSensitiveDataHelper(SoapSecurityMaskSensitiveHelper())
                 setVerbose(true)
                 setPrettyLogging(true)
+                setSensitiveElementNames(setOf("oppdragGjelderId", "utbetalesTilId"))
             })
         }
 

diff --git a/apps/etterlatte-proxy/src/main/kotlin/config/SoapSecurityMaskSensitiveHelper.kt b/apps/etterlatte-proxy/src/main/kotlin/config/SoapSecurityMaskSensitiveHelper.kt
@@ -0,0 +1,18 @@
+package no.nav.etterlatte.config
+
+import org.apache.cxf.ext.logging.MaskSensitiveHelper
+import org.apache.cxf.message.Message
+import java.util.regex.Pattern
+
+/**
+ * Handle tag with multiline content between opening and end.
+ */
+internal class SoapSecurityMaskSensitiveHelper : MaskSensitiveHelper() {
+    private val matchPatternXML = Pattern.compile("(<wsse:Security.*?>)([\\s\\S.]*?)(</wsse:Security>)")
+
+    override fun maskSensitiveElements(message: Message, originalLogString: String): String {
+        val resultString = matchPatternXML.matcher(originalLogString).replaceAll("$1***REDACTED***$3")
+
+        return super.maskSensitiveElements(message, resultString)
+    }
+}
diff --git a/apps/etterlatte-proxy/src/main/kotlin/config/TilbakekrevingConfig.kt b/apps/etterlatte-proxy/src/main/kotlin/config/TilbakekrevingConfig.kt
@@ -22,6 +22,7 @@ class TilbakekrevingConfig(config: Config, private val enableLogging: Boolean =
         val enabledFeatures = mutableListOf<Feature>().apply {
             add(WSAddressingFeature())
             if (enableLogging) add(LoggingFeature().apply {
+                setSensitiveDataHelper(SoapSecurityMaskSensitiveHelper())
                 setVerbose(true)
                 setPrettyLogging(true)
             })

diff --git a/apps/etterlatte-proxy/src/main/kotlin/routes/SimuleringOppdragRoute.kt b/apps/etterlatte-proxy/src/main/kotlin/routes/SimuleringOppdragRoute.kt
@@ -1,12 +1,14 @@
 package no.nav.etterlatte.routes
 
+import io.ktor.http.HttpStatusCode
 import io.ktor.server.application.call
 import io.ktor.server.application.log
 import io.ktor.server.request.receive
 import io.ktor.server.response.respond
 import io.ktor.server.routing.Route
 import io.ktor.server.routing.application
 import io.ktor.server.routing.post
+import no.nav.system.os.eksponering.simulerfpservicewsbinding.SimulerBeregningFeilUnderBehandling
 import no.nav.system.os.eksponering.simulerfpservicewsbinding.SimulerFpService
 import no.nav.system.os.tjenester.simulerfpservice.simulerfpservicegrensesnitt.SimulerBeregningRequest
 
@@ -19,8 +21,13 @@ fun Route.simuleringOppdragRoute(simulerFpService: SimulerFpService) {
     post("/simuleringoppdrag/simulerberegning") {
         val request = call.receive<SimulerBeregningRequest>()
 
-        logger.info("Videresender simuleringsberegning for vedtakId=${request.request.oppdrag.oppdragslinje.first().vedtakId} fra proxy")
-        val response = simulerFpService.simulerBeregning(request)
-        call.respond(response)
+        logger.info("Videresender simuleringsberegning for fagsystemId=${request.request.oppdrag.fagsystemId} fra proxy")
+        try {
+            val response = simulerFpService.simulerBeregning(request)
+            call.respond(response)
+        } catch (e: SimulerBeregningFeilUnderBehandling) {
+            logger.error("Feil ved kall til simuleringstjeneste i Oppdrag", e)
+            call.respond(HttpStatusCode.InternalServerError, e.faultInfo)
+        }
     }
 }