Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: Add actual elapsed duration to timeout exception message. #768

Merged
merged 1 commit into from
Jul 17, 2024
Merged

INTERNAL: Add actual elapsed duration to timeout exception message. #768

merged 1 commit into from
Jul 17, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented Jun 21, 2024

πŸ”— Related Issue

⌨️ What I did

  • CountDownLatch.await() μˆ˜ν–‰ μ „μ˜ μ‹œμ μ„ κΈ°λ‘ν•œ λ’€, Timeout 메세지λ₯Ό 생성할 λ•Œ ν˜„μž¬ μ‹œμ κ³Όμ˜ 차이λ₯Ό κ³„μ‚°ν•©λ‹ˆλ‹€.
  • CountDownLatch.await() μˆ˜ν–‰ μ§ν›„μ˜ μ‹œμ μ„ κΈ°λ‘ν•˜μ§€ μ•Šμ€ μ΄μœ λŠ” λ‹€μŒκ³Ό κ°™μŠ΅λ‹ˆλ‹€.
    • CPUκ°€ μΆ©λΆ„ν•  경우 : CountDownLatch.await() μˆ˜ν–‰ μ§ν›„μ˜ μ‹œμ κ³Ό Timeout 메세지λ₯Ό 생성할 λ•Œμ˜ μ‹œμ μ— 큰 차이가 μ—†μŒ
    • CPUκ°€ λΆ€μ‘±ν•  경우 : Timeout 메세지λ₯Ό 생성할 λ•Œμ˜ μ‹œμ μ„ 선택해야 CPU λΆ€μ‘± μƒνƒœλ₯Ό λ”μš± ν™•μ‹€ν•˜κ²Œ 인지 κ°€λŠ₯

@uhm0311 uhm0311 force-pushed the uhm0311/develop5 branch 2 times, most recently from a150c69 to d8f38eb Compare June 21, 2024 09:25
@uhm0311 uhm0311 marked this pull request as draft June 21, 2024 09:31
@uhm0311 uhm0311 force-pushed the uhm0311/develop5 branch 2 times, most recently from f691106 to 5417cb6 Compare June 21, 2024 10:13
@uhm0311 uhm0311 marked this pull request as ready for review June 21, 2024 10:13
@uhm0311 uhm0311 requested a review from brido4125 June 25, 2024 05:06
brido4125
brido4125 previously approved these changes Jun 25, 2024
View reviewed changes
oliviarla
oliviarla previously approved these changes Jun 25, 2024
View reviewed changes
src/main/java/net/spy/memcached/MemcachedClient.java Outdated Show resolved Hide resolved
@uhm0311 uhm0311 dismissed stale reviews from oliviarla and brido4125 via a79349a June 25, 2024 08:40
oliviarla
oliviarla previously approved these changes Jun 25, 2024
View reviewed changes
jhpark816
jhpark816 reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œ

src/main/java/net/spy/memcached/internal/OperationFuture.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/internal/OperationFuture.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/OperationTimeoutException.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/internal/BulkGetFuture.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/MemcachedClient.java Outdated Show resolved Hide resolved
@uhm0311 uhm0311 mentioned this pull request Jul 9, 2024
Merged
@jhpark816
Copy link
Collaborator

@uhm0311 rebase λ°”λžλ‹ˆλ‹€.

@uhm0311 uhm0311 requested a review from jhpark816 July 15, 2024 02:37
@uhm0311
Copy link
Collaborator Author

uhm0311 commented Jul 15, 2024

@jhpark816

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

oliviarla
oliviarla previously approved these changes Jul 16, 2024
View reviewed changes
jhpark816
jhpark816 reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œ

src/main/java/net/spy/memcached/internal/BroadcastFuture.java
@@ -66,7 +69,7 @@ public T get(long duration, TimeUnit unit)
}
}
if (!timedOutOps.isEmpty()) {
throw new CheckedOperationTimeoutException(duration, unit, timedOutOps);
throw new CheckedOperationTimeoutException(duration, unit, elapsed, timedOutOps);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—¬κΈ° if λ¬Έ μ•ˆμ—μ„œλ§Œ elapsed κ³„μ‚°ν•˜λ©΄ 될 것 같은 λ°μš”.
ν˜„μž¬ PRκ³Ό 같이 무쑰건 elapsed κ³„μ‚°ν•˜λŠ” 것이 λ‚˜μ€κ°€μš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

@jhpark816 jhpark816 merged commit 776b893 into naver:develop Jul 17, 2024
3 checks passed
@uhm0311 uhm0311 deleted the uhm0311/develop5 branch July 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 approved these changes

@oliviarla oliviarla oliviarla left review comments

@brido4125 brido4125 Awaiting requested review from brido4125

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uhm0311 @jhpark816 @oliviarla @brido4125