FIX: change cancel method logic in OperationFuture. #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
requested changes
Jul 14, 2023
| public boolean cancel(boolean ign) { | ||
| assert op != null : "No operation"; | ||
| if (op.getState().equals(OperationState.COMPLETE)) { |
There was a problem hiding this comment.
enum이니까 == 연산으로 비교해도 됩니다.
| public boolean isDone() { | ||
| assert op != null : "No operation"; | ||
| return latch.getCount() == 0 || | ||
| op.isCancelled() || op.getState() == OperationState.COMPLETE; |
There was a problem hiding this comment.
두 메소드에 변경 사항이 없어 보입니다. 원래 있던 위치에 놓아주세요.
There was a problem hiding this comment.
생성자 -> 오버라이드된 메서드 -> 인스턴스 메서드 순으로
다른 Future에서도 메서드 정렬 방식을 가져가고 있어서 유지하려고 합니다.
There was a problem hiding this comment.
그 변경사항은 현재 커밋 메세지에 어울리지 않으니, 다른 PR로 반영하도록 합시다.
brido4125
force-pushed
the
fix/singleOpCancel
branch
from
5ec258a
to
4875ae7
Compare
brido4125
force-pushed
the
fix/singleOpCancel
branch
from
4875ae7
to
a47fa4f
Compare
uhm0311
approved these changes
Jul 17, 2023
jhpark816
reviewed
Jul 17, 2023
| // This isn't exactly correct, but it's close enough. If we're in | ||
| // a writing state, we *probably* haven't started. | ||
| return op.getState() == OperationState.WRITE_QUEUED; | ||
| return op.getState() != OperationState.COMPLETE; |
There was a problem hiding this comment.
return true; 해도 될 것 같은 데, getState() 다시 확인하는 이유가 있나요?
There was a problem hiding this comment.
return true로 변경하는게 더 이해하기 쉬울것 같습니다.
별 다른 이유는 없었습니다.
brido4125
force-pushed
the
fix/singleOpCancel
branch
from
a47fa4f
to
3628823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
https://github.com/jam2in/arcus-works/issues/419
Motivation
기존의 단일 Op를 가지는 Future의 cancel 로직은 아래와 같은 문제가 있다.
아래의 세가지 경우를 고려하지 않고
모든 case에 대해 op.cancel()을 호출시킨다.
그리고
OperationState.WRITE_QUEUED를 기준으로cancel()의 성공 및 실패 여부를 알려준다.
만약 op가 완료 된 후, cancel() 요청이 들어올 경우
응답값은 false로 정상적으로 돌려준다.
하지만 cancel() 요청 후, get() 메서드를 호출할 경우엔
ExecutionException을 발생시킨다.즉, 작업의 완료로 인해 cancel이 실패하였음에도
cancel에 의한 예외가 발생한다.
정상 동작은 예외가 발생하지 않고 완료된 결과를 리턴해줘야한다.
변경 후 로직
OperationState.WRITE_QUEUEDOperationState.READING,OperationState.WRITINGOperationState.COMPLETE참고로 single Op만을 가지는
Future들은 모두OperationFuture의cancel()구현을 사용합니다.