Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buying links #1049

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update buying links #1049

wants to merge 2 commits into from

Conversation

tuantinghuang
Copy link
Collaborator

@tuantinghuang tuantinghuang commented Nov 3, 2024

Relate to issue #1008

On the top nav bar, I switched the "buying options" dropdown menu into "buyers guide" button.
Also on the landing page, I updated the buying options and the buttons layout.

( a preview without the "order direct" shopify button)
Screenshot 2024-11-03 at 22 19 49

@jasongao97 Can I have your help with making the '*includes exclusive bookmark and sticker!' note on the same line with the "order direct" button? (now it's one line beneath the button)

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for nature-of-code-2nd-edition ready!

Name Link
🔨 Latest commit c4dafd1
🔍 Latest deploy log https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/6728c1de55e57d00083d7117
😎 Deploy Preview https://deploy-preview-1049--nature-of-code-2nd-edition.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasongao97
Copy link
Contributor

Sure! I also made some adjustments to fit it on mobile screen.

@shiffman
Copy link
Member

shiffman commented Nov 4, 2024

After some thought I think we shoudl go back to the original menu as displayed here:

Description of the image

And just add one last item for "Buyer's Guide" would "Intl. Buyer's Guide" fit? Another option is "Global Retailers" Then let's also add it as one more button at the bottom:

image

Playing with the deploy preview it's jarring to be taken away to a Github repo and it's not easy to quickly find the links. That page is best for someone who wants to do a deep dive into international options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants