Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa for icon button #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qa for icon button #423

wants to merge 1 commit into from

Conversation

hayna-foursys
Copy link
Collaborator

Description

Please include a summary of the changes and features that were added. Also include in the title which JIRA task is this related. Don't forget to list any dependencies that were added or removed for this change. If your code adds a breaking change, describe the reason and what was changed.

Type of change

  • feat: adds a new feature for the user, not a new feature for build script
  • fix: fixes a bug for the user, not a fix to a build script
  • docs: changes to the documentation
  • style: formatting, missing semi colons, etc; no production code change
  • refactor: refactoring production code, eg. renaming a variable
  • test: adding missing tests, refactoring tests; no production code change
  • chore: updating grunt tasks etc; no production code change
  • my change adds a breaking change (add at description!)

Checklist

  • My commits follow the Conventional Commits guidelines
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant