Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for isolate v2 #112

Merged
merged 12 commits into from
Sep 14, 2024
Merged

Conversation

minhnhatnoe
Copy link
Contributor

On startup, check for the isolate daemon's status (or run the daemon as a goroutine if in docker container). Processes in the container's root cgroup will be moved to the subgroup /daemon by the custom isolate.

@minhnhatnoe minhnhatnoe marked this pull request as draft April 29, 2024 05:10
@minhnhatnoe minhnhatnoe marked this pull request as ready for review May 6, 2024 03:50
@minhnhatnoe
Copy link
Contributor Author

You might also want to merge changes from master branch at https://github.com/minhnhatnoe/kjudge.wiki.git. I have added notes about using --cap-add instead of --privileged.

@natsukagami
Copy link
Owner

Think we can YOLO this one for now ^^

@@ -51,7 +38,7 @@ RUN scripts/install_tools.sh
RUN go generate && go build -tags production -o kjudge cmd/kjudge/main.go

# Stage 3: Create awesome output image
FROM base-ubuntu
FROM ghcr.io/minhnhatnoe/isolate:v2.1.5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO put this somewhere centralized alongside other versioned stuff

Copy link
Owner

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yolo:

@natsukagami natsukagami added this to the v0.8.0 "Kirifu Megumi" milestone Sep 14, 2024
@natsukagami natsukagami merged commit bdd9670 into natsukagami:master Sep 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants