Default settings local var

natsukagami · Jun 24, 2023 · ced0c3f · ced0c3f
1 parent 7e7822f
commit ced0c3f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/worker/sandbox.go b/worker/sandbox.go
@@ -8,10 +8,7 @@ import (
 )
 
 func NewSandbox(name string, options ...sandbox.Option) (sandbox.Runner, error) {
-	setting := sandbox.DefaultSettings
-	for _, option := range options {
-		setting = option(setting)
-	}
+	setting := sandbox.MakeSettings(options...)
 	switch name {
 	case "raw":
 		return raw.New(setting), nil

diff --git a/worker/sandbox/settings.go b/worker/sandbox/settings.go
@@ -5,7 +5,7 @@ type Settings struct {
 	IgnoreWarning bool
 }
 
-var DefaultSettings = Settings{LogSandbox: true, IgnoreWarning: false}
+var defaultSettings = Settings{LogSandbox: true, IgnoreWarning: false}
 
 type Option func(Settings) Settings
 
@@ -22,3 +22,11 @@ func EnableSandboxLogs(enable bool) Option {
 		return o
 	}
 }
+
+func MakeSettings(options ...Option) Settings {
+	setting := defaultSettings
+	for _, option := range options {
+		setting = option(setting)
+	}
+	return setting
+}