Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Pacakge Download Size #181

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Reduce Pacakge Download Size #181

merged 1 commit into from
Dec 5, 2023

Conversation

natsuk4ze
Copy link
Owner

@natsuk4ze natsuk4ze commented Dec 5, 2023

This change brings the package size from 1 MB to 500 KB.

The assets in the example folder is required to run the example code, but not for package users.

Basically, package users clone the repository when they run example, so we should add it to .pubignore.

🚨 .pubignore and .gitignore must not be included in the same dir hierarchy

See:

@natsuk4ze natsuk4ze changed the title Add .pubignore for example assets Reduce Pacakge Download Size Dec 5, 2023
@natsuk4ze natsuk4ze marked this pull request as ready for review December 5, 2023 03:56
@natsuk4ze natsuk4ze merged commit 2fd83ec into main Dec 5, 2023
18 checks passed
@natsuk4ze natsuk4ze deleted the Reduce-Package-Size branch December 5, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant