Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin platform interface #180

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Add Plugin platform interface #180

merged 7 commits into from
Dec 5, 2023

Conversation

natsuk4ze
Copy link
Owner

@natsuk4ze natsuk4ze commented Dec 4, 2023

Add plugin platform interface to allow Non-endorsed federated plugin

Linux support is determined to be beyond the owner's capacity, so we will pseudo-add Linux support by making it extensible as a non-endorsed federated plugin. packages for Linux will be released later by @freshtechtips . See: #178 #164

These non-endorsed federated plugins may be incorporated into endorsed federated plugins or gal repositories in the future.

Close #163

@natsuk4ze natsuk4ze marked this pull request as ready for review December 4, 2023 11:04
@natsuk4ze natsuk4ze marked this pull request as draft December 4, 2023 11:08
import 'gal_method_channel.dart';

/// Plugin Platform Interface
abstract class GalPlatform extends PlatformInterface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use the base keyword from dart 3

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! I forgot that

The PlatformInterface class is used to enforce `extends`, which is replaced by Dart 3's `base`.

See:flutter/flutter#127396
@natsuk4ze natsuk4ze marked this pull request as ready for review December 4, 2023 12:52
@natsuk4ze natsuk4ze marked this pull request as draft December 4, 2023 13:19
@natsuk4ze natsuk4ze marked this pull request as ready for review December 5, 2023 07:25
@natsuk4ze natsuk4ze merged commit 8f54585 into main Dec 5, 2023
18 checks passed
@natsuk4ze natsuk4ze deleted the plugin_platform_interface branch December 5, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Linux desktop platform
2 participants