Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nats helm] set probe scheme based on monitor tls #806

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[nats helm] set probe scheme based on monitor tls #806

merged 1 commit into from
Oct 2, 2023

Conversation

caleblloyd
Copy link
Contributor

Resolves #805

@caleblloyd caleblloyd mentioned this pull request Oct 2, 2023
Merged
wallyqs
wallyqs approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caleblloyd caleblloyd merged commit 7fb4b2c into main Oct 2, 2023
5 checks passed
@caleblloyd caleblloyd deleted the tls-monitor branch October 2, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@samuelattwood samuelattwood Awaiting requested review from samuelattwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATS Chart Probes not Using HTTPS when Monitor TLS is Enabled
2 participants
@caleblloyd @wallyqs