Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to "## Basic functionality: Add tasks" #112

Merged
merged 2 commits into from
Apr 28, 2018
Merged

Add to "## Basic functionality: Add tasks" #112

merged 2 commits into from
Apr 28, 2018

Conversation

hines-sharrod
Copy link
Contributor

As I was working through the tutorial I could not figure out why my list would not show up. I think it would be wise to make sure it is stated not to forget to set a height on the component.

As I was working through the tutorial I could not figure out why my list would not show up. I think it would be wise to make sure it is stated not to forget to set a height on the <ListView> component.
@nativescript-vue-bot
Copy link

nativescript-vue-bot commented Apr 26, 2018

Deploy preview for nativescript-vue ready!

Built with commit 209a372

https://deploy-preview-112--nativescript-vue.netlify.com

I forgot the > add the end of my List View component.
@rigor789
Copy link
Member

Hey @ikoevska since you wrote this part, I thought I'd ping you to take a look!

@hines-sharrod
Copy link
Contributor Author

Great, thank you. @ikoevska I just added those notes because my ListView component did not display for the To Do tab until I added a height. I randomly figured out that was the error, so I am sure more people are facing the same issue. Also, this was on iOS by the way.

@hines-sharrod
Copy link
Contributor Author

If I am mistaken then there may be a bug because that is the only way it would show up.

@ikoevska
Copy link
Contributor

ikoevska commented Apr 27, 2018

@rigor789 thanks for pinging me! @hines-sharrod, the changes look good.

I just tested it and you're right - the ListView no longer shows if you don't have height. (At the time of writing this it worked without the property.) I'll note in the ListView docs as well. (Added issue: #113)

@hines-sharrod
Copy link
Contributor Author

@ikoevska Okay great, glad that I could catch that and help out.

@hines-sharrod
Copy link
Contributor Author

RANDOM QUESTION: Being that this was my first pull request and it did add value I wondered does that mean I will be added to the page as a contributor? @rigor789 @ikoevska

@ikoevska
Copy link
Contributor

I'll leave it to @rigor789 to confirm if it's OK but basically you can just go to the top where there's a contributors meta data field and add your github handle there :)

@ikoevska
Copy link
Contributor

@rigor789 can you merge this as I'd like to work some more on the tutorial and I'd like to get the updated version. Thanks!

@rigor789 rigor789 merged commit 16810b9 into nativescript-vue:master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants