Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ListView page #113

Open
ikoevska opened this issue Apr 27, 2018 · 2 comments
Open

Update ListView page #113

ikoevska opened this issue Apr 27, 2018 · 2 comments

Comments

@ikoevska
Copy link
Contributor

ListView now requires the height property to work (at least on iOS). We need to update the docs page for that.

@rigor789
Copy link
Member

This is only the case when used in a StackLayout and this has been true for vanilla nativescript as well. What I personally suggest most of the time is to use a GridLayout which has far less issues than a StackLayout (and it is more performant).

Throughout the docs we reference StackLayout quite often and the reason is that it's the easiest layout to understand, but not the best one... This is a double edge sword, because on one hand I'd like to keep the docs easy to understand, but on the other hand I want to suggest things that I'd actually use in production.

Anyways, for this case we can mention in a note, that when used in a StackLayout a height should be applied.

@hines-sharrod
Copy link
Contributor

hines-sharrod commented Apr 27, 2018

@rigor789 I know you do not want to make the documentation seem more complex, but for me personally I feel that you providing what I would call "NativeScript best practices" within the docs would be helpful.

This would be great for new users reading through especially since they may think that the StackLayout is the best since it used so often throughout. I know it could seem like you are adding a bias to it, but I see no harm in finding out your recommendations on when and where to use different UI components and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants