Merge pull request #990 from nathanreyes/bug/events-memory-cleanup

Fix event removal
nathanreyes · Oct 6, 2021 · 43b3834 · 43b3834
2 parents ef19744 + ec83a58
commit 43b3834
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/docs/changelog/v2.0.md b/docs/changelog/v2.0.md
@@ -502,4 +502,9 @@ Fixes single use of `highlight.contentStyle` or `highlight.contentClass`
 * Dependabot updates
 
 ### Improvements
-* Remove custom click detection handlers for Mobile Safari
+* Remove custom click detection handlers for Mobile Safari
+
+## v2.3.4
+
+### Bug Fixes
+* Fix event removal in date picker
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "v-calendar",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "private": false,
   "description": "A clean and extendable plugin for building simple attributed calendars in Vue.js.",
   "author": "Nathan Reyes <[email protected]>",

diff --git a/src/components/DatePicker.vue b/src/components/DatePicker.vue
@@ -366,7 +366,7 @@ export default {
   },
   destroyed() {
     off(document, 'keydown', this.onDocumentKeyDown);
-    on(document, 'click', this.onDocumentClick);
+    off(document, 'click', this.onDocumentClick);
   },
   methods: {
     getDateParts(date) {