Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #551, when rebalance ,remove out of date assignment #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinceyang
Copy link

to fixes #551 ,when rebalance the rebalance topolgy's assignment has out of date ,must clear these assignment from zookeeper,.

@revans2
Copy link
Contributor

revans2 commented Sep 18, 2013

This does seem like it will fix the re-balancing issue, but it does not address other schedulers that might take all resources from a previously running topology.

@herberteuler
Copy link
Contributor

My reference was a mistake. Sorry for that.

@vinceyang
Copy link
Author

@revans2 , scheduler address all resources from a previously running topology,.seems we have to mark all topology's a flag to describe does topology in effect. supervisor Ignore the renbalancing topology's assigment. do you have any idea?

@revans2
Copy link
Contributor

revans2 commented Sep 23, 2013

@vinceyang I am not really sure what you mean by that. The scheduler looks at the cluster as a whole and all topologies that have been requested to run on it. It has the power to remove or change assignments for any topology as it sees fit. I found that when a scheduler removes all of the assignments for a previously running topology, the code that decides if it should update ZK makes a mistake and does not update ZK.

I simply pointed out that the current patch seems to fix the case for a rebalance that can cause a scheduler to remove the resources for a previously running topology, but it does not address the general case where a scheduler might do the same thing for a different reason. Assume that there is a priority queue and a higher priority topology comes in so the lowest priority topology is stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants