Resolve absolute path to operatorsFile #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #115 Custom `operatorsFile` configs in .tidyrc were not resolving correctly. Previously we were using `relative dir operatorsFile`, but if `operatorsFile` was a relative path (which is the common case), then the behavior of `relative` is to treat `operatorsFile` as relative to `cwd` initially (I think it's an error that `relative` is typed as a pure function). Thus, this only works (reduntantly) if `cwd` is the same as the `.tidyrc.json` parent directory. We should be using `resolve [ dir ]` instead to get an absoute path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Custom
operatorsFileconfigs in .tidyrc were not resolving correctly. Previously we were usingrelative dir operatorsFile, but ifoperatorsFilewas a relative path (which is the common case), then the behavior ofrelativeis to treatoperatorsFileas relative tocwdinitially (I think it's an error thatrelativeis typed as a pure function). Thus, this only works (reduntantly) ifcwdis the same as the.tidyrc.jsonparent directory.We should be using
resolve [ dir ]instead to get an absoute path.