Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7892): restore "now" (marcus bains) line to planning views #7898

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 17, 2024

Closes #7892

Describe your changes:

Initialize alignment offset to 0. (it was undefined). This fixes the now line issue.
Also handle a small bug with swimlane configuration not getting replaced when the plan used by a gantt chart was changed

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

…mall bug with swimlane configuration not getting replaced when the plan used by a gantt chart was changed
@shefalijoshi shefalijoshi added this to the Build 9 RC11 milestone Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.40%. Comparing base (7f8b5e0) to head (628fe36).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7898      +/-   ##
==========================================
+ Coverage   57.11%   57.40%   +0.29%     
==========================================
  Files         676      676              
  Lines       27355    27357       +2     
  Branches     2685     2685              
==========================================
+ Hits        15623    15705      +82     
+ Misses      11394    11314      -80     
  Partials      338      338              
Flag Coverage Δ
e2e-ci 62.38% <ø> (-0.07%) ⬇️
e2e-full 41.77% <ø> (+18.31%) ⬆️
unit 49.29% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
src/plugins/plan/components/PlanView.vue 59.49% <100.00%> (+0.17%) ⬆️
src/ui/components/TimeSystemAxis.vue 65.88% <100.00%> (-3.17%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8b5e0...628fe36. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@ozyx ozyx changed the title Now marker for plans fixed. fix(#7892): restore "now" (marcus bains) line to planning views Oct 17, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@ozyx ozyx enabled auto-merge (squash) October 17, 2024 20:57
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx merged commit 3e23dce into master Oct 17, 2024
44 checks passed
@ozyx ozyx deleted the plan-now-marker-fix branch October 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marcus Bains "now" line broken in Plan and Gantt views
2 participants