-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7825): imagery pause #7842
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7842 +/- ##
==========================================
- Coverage 59.11% 56.92% -2.19%
==========================================
Files 675 675
Lines 27284 27287 +3
Branches 2671 2671
==========================================
- Hits 16128 15533 -595
- Misses 11108 11417 +309
- Partials 48 337 +289
... and 105 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split out the test
So I agree this would be more readable in isolation, but this uber test runs against multiple imagery views so it makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// go way forward in time to ensure multiple images are discarded | ||
const IMAGES_TO_DISCARD_COUNT = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fantastic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this is supposed to be for the whole test part)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its okay. I know my const
s are world renowned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dave "Some of the Best Consts" Tsay
@unlikelyzero , can you re-review? Do you still want me to break up the tests, or is this good as is? |
@unlikelyzero , tests are updated and |
Closes #7825
Describe your changes:
Fixed
imageryData.dataRemoved
method to properly remove multiple imagesNote: This is fixing the current implementation. A better approach would be to not rely on keeping a mirrored
imageHistory
in sync with the underlyingtelemetryCollection
.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist