Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7825): imagery pause #7842

Merged
merged 17 commits into from
Sep 27, 2024
Merged

fix(#7825): imagery pause #7842

merged 17 commits into from
Sep 27, 2024

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Sep 12, 2024

Closes #7825

Describe your changes:

Fixed imageryData.dataRemoved method to properly remove multiple images
Note: This is fixing the current implementation. A better approach would be to not rely on keeping a mirrored imageHistory in sync with the underlying telemetryCollection.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.92%. Comparing base (e792403) to head (c82bcbd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/imagery/components/ImageryView.vue 0.00% 2 Missing ⚠️
src/plugins/timeline/TimelineViewLayout.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7842      +/-   ##
==========================================
- Coverage   59.11%   56.92%   -2.19%     
==========================================
  Files         675      675              
  Lines       27284    27287       +3     
  Branches     2671     2671              
==========================================
- Hits        16128    15533     -595     
- Misses      11108    11417     +309     
- Partials       48      337     +289     
Flag Coverage Δ
e2e-ci 61.77% <100.00%> (-0.02%) ⬇️
e2e-full 23.51% <0.00%> (-18.44%) ⬇️
unit 49.34% <72.72%> (-1.87%) ⬇️
Files with missing lines Coverage Δ
src/api/telemetry/TelemetryCollection.js 86.93% <ø> (ø)
src/plugins/imagery/components/ImageryTimeView.vue 75.00% <100.00%> (-5.33%) ⬇️
src/plugins/imagery/mixins/imageryData.js 96.59% <100.00%> (+0.03%) ⬆️
src/plugins/timeline/TimelineViewLayout.vue 56.00% <0.00%> (-4.82%) ⬇️
src/plugins/imagery/components/ImageryView.vue 41.99% <0.00%> (-6.60%) ⬇️

... and 105 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e792403...c82bcbd. Read the comment docs.

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split out the test

@davetsay
Copy link
Contributor Author

davetsay commented Sep 12, 2024

Let's split out the test

So I agree this would be more readable in isolation, but this uber test runs against multiple imagery views so it makes sense.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 750 to 751
// go way forward in time to ensure multiple images are discarded
const IMAGES_TO_DISCARD_COUNT = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fantastic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is supposed to be for the whole test part)

Copy link
Contributor Author

@davetsay davetsay Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okay. I know my consts are world renowned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dave "Some of the Best Consts" Tsay

@ozyx ozyx added the type:bug label Sep 12, 2024
@ozyx ozyx added this to the Target:4.0.1 milestone Sep 12, 2024
@ozyx ozyx changed the title Bugfix/7825 imagery pause fix(#7825): imagery pause Sep 13, 2024
@davetsay
Copy link
Contributor Author

@unlikelyzero , can you re-review? Do you still want me to break up the tests, or is this good as is?

@davetsay
Copy link
Contributor Author

@unlikelyzero , tests are updated and @clock tests are split out. Can you re-review?

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 27, 2024
@unlikelyzero unlikelyzero merged commit a8fbabe into master Sep 27, 2024
29 of 31 checks passed
@unlikelyzero unlikelyzero deleted the bugfix/7825-imagery-pause branch September 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Imagery] Some images not being bounded properly
4 participants