-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAS-2146 - select correct asset from stac Item #14
Conversation
Verified with tests and regression tests.
This probably works, but it is a first try.
Tests each case for finding correct asset in Item.
Also updates changelog with info on how to keep it up to date and adds links to version diffs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I only had super minor nits on the code and tests.
The other quick question: is this change meant to trigger an associated release? If so, it doesn't look like changes to docker/service_version.txt
and CHANGELOG.md
got pushed up to remote.
When I added the link to the version diffs in github, I neglected to correct the script that pulls out the changelog information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the image and ran the tests successfully, then in turn locally executed the HyBIG_Regression.ipynb notebook, which was also successful.
The code looked pretty straightforward to me. I just noted a couple typos.
Description
Adds a function to BrowseImageGeneratorAdapter to select correct asset for generating browse images when multiple files are present in the granule.
Though a combination of updating the UMM-G record with a new subtype of "BROWSE IMAGE SOURCE" and HARMONY-1751. Harmony can now present assets that include a role of 'visual'.
HyBIG has been modified to select an assets with role 'visual' before falling back to a role 'data' as before.
Jira Issue ID
DAS-2146
Local Test Steps
Pull this branch, build and run the tests.
If those pass, you can deploy to your Harmony-In-A-Box and run the regression tests against localhost.
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.