Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions ahead of NodeJS deprecation #2890

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

thomas-bc
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Several Actions have been emitting warnings because of deprecation of NodeJS 16 - this change is to upgrade to the newer version, as per recommendation from GitHub.

e.g. see https://github.com/actions/upload-artifact?tab=readme-ov-file#actionsupload-artifact

@LeStarch
Copy link
Collaborator

Note: this does not work on our native image builds running in manylinux2014 containers. There we need to maintain the older node js version....as the new one crashes.

@thomas-bc
Copy link
Collaborator Author

Merging without RPI LedBlinker check as we know it has been causing issues, unrelated to this code change

@thomas-bc thomas-bc merged commit 60fbd1e into nasa:devel Sep 23, 2024
33 of 34 checks passed
@thomas-bc thomas-bc deleted the upgrade-gh-actions branch September 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants