Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Os::FileSystem and Os::Directory #2871

Merged
merged 45 commits into from
Sep 27, 2024

Fix DpCatalog unchecked return value

9c348b3
Select commit
Loading
Failed to load commit list.
Merged

Refactor Os::FileSystem and Os::Directory #2871

Fix DpCatalog unchecked return value
9c348b3
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Sep 27, 2024 in 9s

118 new alerts

New alerts in code changed by this pull request

  • 15 warnings
  • 103 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 94 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter fileCount has not been checked.

Check warning on line 127 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter filenameCount has not been checked.

Check warning on line 61 in Os/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter totalBytes has not been checked.

Check warning on line 61 in Os/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter freeBytes has not been checked.

Check warning on line 309 in Os/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unbounded loop Warning

The loop counter copiedSize is not always incremented in the loop body.

Check warning on line 42 in Os/Posix/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter path has not been checked.

Check warning on line 78 in Os/Posix/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unbounded loop Warning

This loop does not have a fixed bound.

Check warning on line 69 in Os/Posix/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 75 in Os/Posix/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter bufSize has not been checked.

Check warning on line 47 in Os/Posix/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 67 in Os/Posix/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter path has not been checked.

Check warning on line 81 in Os/Posix/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter freeBytes has not been checked.

Check warning on line 82 in Os/Posix/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter totalBytes has not been checked.

Check warning on line 53 in Os/Posix/error.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter errno_input has not been checked.

Check warning on line 108 in Os/Posix/error.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter errno_input has not been checked.

Check notice on line 90 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

loopLimit uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 91 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

count uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 92 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

unusedBuffer uses the basic integral type char rather than a typedef with size and signedness.

Check notice on line 96 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

iter uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 113 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

filenameArraySize uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 113 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

filenameCount uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 126 in Os/Directory.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

index uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice on line 214 in Os/Directory.hpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

m_is_open uses the basic integral type bool rather than a typedef with size and signedness.

Check notice on line 26 in Os/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

path uses the basic integral type char rather than a typedef with size and signedness.

Check notice on line 32 in Os/FileSystem.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

path uses the basic integral type char rather than a typedef with size and signedness.