Fix double-promotion in fprime codebase (#2818)

CMakeLists.txt

@@ -24,12 +24,14 @@ add_compile_options(
     -Wno-unused-parameter
 )
 
-# Add -Wshadow and -pedantic only for framework code, not the unit tests
+# Add -Wshadow, -Wconversion and -pedantic only for framework code, not the unit tests
+# TODO: uncomment -Wdouble-promotion once fpp is fixed
 if (NOT BUILD_TESTING)
     add_compile_options(
         -Wshadow
         -pedantic
         -Wconversion
+#        -Wdouble-promotion
     )
 endif()
 

Fw/Types/PolyType.cpp

@@ -639,12 +639,16 @@ void PolyType::toString(StringBase& dest, bool append) const {
 #endif
 #if FW_HAS_F64
         case TYPE_F64:
-            (void)snprintf(valString, sizeof(valString), "%lg ", this->m_val.f64Val);
+            (void)snprintf(valString, sizeof(valString), "%g ", this->m_val.f64Val);
             break;
-#endif
+        case TYPE_F32:
+            (void)snprintf(valString, sizeof(valString), "%g ", static_cast<F64>(this->m_val.f32Val));
+            break;
+#else
         case TYPE_F32:
             (void)snprintf(valString, sizeof(valString), "%g ", this->m_val.f32Val);
             break;
+#endif
         case TYPE_BOOL:
             (void)snprintf(valString, sizeof(valString), "%s ", this->m_val.boolVal ? "T" : "F");
             break;

Fw/Types/StringUtils.cpp

@@ -64,7 +64,7 @@ FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string,
         return -1;
     }
     // Confirm that the output type can hold the range of valid results
-    FW_ASSERT((source_size - sub_size) <= std::numeric_limits<FwSignedSizeType>::max());
+    FW_ASSERT(static_cast<FwSignedSizeType>(source_size - sub_size) <= std::numeric_limits<FwSignedSizeType>::max());
 
     // Loop from zero to source_size - sub_size (inclusive)
     for (FwSizeType source_index = 0;