Merge pull request #271 from tiffany1618/fix-serial-connector

Remove redundant serial connector function
nasa · Jul 12, 2023 · 2090341 · 2090341
2 parents 9f72933 + 9b1ee14
commit 2090341
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 91 deletions.
diff --git a/compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentPorts.scala b/compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentPorts.scala
@@ -32,7 +32,6 @@ case class ComponentPorts(
       inputPortWriter.getGetters(serialInputPorts),
       outputPortWriter.getTypedConnectors(specialOutputPorts),
       outputPortWriter.getTypedConnectors(typedOutputPorts),
-      outputPortWriter.getTypedConnectors(serialOutputPorts),
       outputPortWriter.getSerialConnectors(specialOutputPorts),
       outputPortWriter.getSerialConnectors(typedOutputPorts),
       outputPortWriter.getSerialConnectors(serialOutputPorts),

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.cpp b/compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.cpp
@@ -1282,24 +1282,6 @@ void ActiveSerialComponentBase ::
   this->m_typedReturnOut_OutputPort[portNum].addCallPort(port);
 }
 
-// ----------------------------------------------------------------------
-// Connect serial input ports to serial output ports
-// ----------------------------------------------------------------------
-
-void ActiveSerialComponentBase ::
-  set_serialOut_OutputPort(
-      NATIVE_INT_TYPE portNum,
-      Fw::InputSerializePort* port
-  )
-{
-  FW_ASSERT(
-    portNum < this->getNum_serialOut_OutputPorts(),
-    static_cast<FwAssertArgType>(portNum)
-  );
-
-  this->m_serialOut_OutputPort[portNum].registerSerialPort(port);
-}
-
 #if FW_PORT_SERIALIZATION
 
 // ----------------------------------------------------------------------

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.hpp b/compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.hpp
@@ -441,18 +441,6 @@ class ActiveSerialComponentBase :
         InputTypedReturnPort* port //!< The input port
     );
 
-  public:
-
-    // ----------------------------------------------------------------------
-    // Connect serial input ports to serial output ports
-    // ----------------------------------------------------------------------
-
-    //! Connect port to serialOut[portNum]
-    void set_serialOut_OutputPort(
-        NATIVE_INT_TYPE portNum, //!< The port number
-        Fw::InputSerializePort* port //!< The input port
-    );
-
 #if FW_PORT_SERIALIZATION
 
   public:

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.cpp b/compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.cpp
@@ -876,24 +876,6 @@ void PassiveSerialComponentBase ::
   this->m_typedReturnOut_OutputPort[portNum].addCallPort(port);
 }
 
-// ----------------------------------------------------------------------
-// Connect serial input ports to serial output ports
-// ----------------------------------------------------------------------
-
-void PassiveSerialComponentBase ::
-  set_serialOut_OutputPort(
-      NATIVE_INT_TYPE portNum,
-      Fw::InputSerializePort* port
-  )
-{
-  FW_ASSERT(
-    portNum < this->getNum_serialOut_OutputPorts(),
-    static_cast<FwAssertArgType>(portNum)
-  );
-
-  this->m_serialOut_OutputPort[portNum].registerSerialPort(port);
-}
-
 #if FW_PORT_SERIALIZATION
 
 // ----------------------------------------------------------------------

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.hpp b/compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.hpp
@@ -361,18 +361,6 @@ class PassiveSerialComponentBase :
         InputTypedReturnPort* port //!< The input port
     );
 
-  public:
-
-    // ----------------------------------------------------------------------
-    // Connect serial input ports to serial output ports
-    // ----------------------------------------------------------------------
-
-    //! Connect port to serialOut[portNum]
-    void set_serialOut_OutputPort(
-        NATIVE_INT_TYPE portNum, //!< The port number
-        Fw::InputSerializePort* port //!< The input port
-    );
-
 #if FW_PORT_SERIALIZATION
 
   public:

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.cpp b/compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.cpp
@@ -1282,24 +1282,6 @@ void QueuedSerialComponentBase ::
   this->m_typedReturnOut_OutputPort[portNum].addCallPort(port);
 }
 
-// ----------------------------------------------------------------------
-// Connect serial input ports to serial output ports
-// ----------------------------------------------------------------------
-
-void QueuedSerialComponentBase ::
-  set_serialOut_OutputPort(
-      NATIVE_INT_TYPE portNum,
-      Fw::InputSerializePort* port
-  )
-{
-  FW_ASSERT(
-    portNum < this->getNum_serialOut_OutputPorts(),
-    static_cast<FwAssertArgType>(portNum)
-  );
-
-  this->m_serialOut_OutputPort[portNum].registerSerialPort(port);
-}
-
 #if FW_PORT_SERIALIZATION
 
 // ----------------------------------------------------------------------

diff --git a/compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.hpp b/compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.hpp
@@ -441,18 +441,6 @@ class QueuedSerialComponentBase :
         InputTypedReturnPort* port //!< The input port
     );
 
-  public:
-
-    // ----------------------------------------------------------------------
-    // Connect serial input ports to serial output ports
-    // ----------------------------------------------------------------------
-
-    //! Connect port to serialOut[portNum]
-    void set_serialOut_OutputPort(
-        NATIVE_INT_TYPE portNum, //!< The port number
-        Fw::InputSerializePort* port //!< The input port
-    );
-
 #if FW_PORT_SERIALIZATION
 
   public: