-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add when-then-otherwise expression #588
feat: add when-then-otherwise expression #588
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
72327b6
to
d8bc8b7
Compare
fixed by xfail fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aivanoved ! I just pushed some slight changes to avoid using nullable dtypes when the user didn't ask for them
Thank you @aivanoved for working this! This is a great addition |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
This PR so far adds a simple
when-then-otherwise
expression with no chainingThe PR does not aim to be complete as of now, the current aim is to get an initial review as to if this approach is consistent with the project's quality and style of codeTODO:
Iterable[IntoPandasExpr]
to the pandas API forpredicates
Allowobsolete: see comments below and enh: improve when-then-otherwise to include chaining #668when-then-otherwise
chainingNote: Temporary converted back to draft due to a git rebase issuefixedNote: due to an unfortunate rebase gone wrong, the commit history is a mess, we could open a new pr from a new branch or when merging do a squash merge. Further advice on this would be much appreciated.