-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request bioconda release of newest version #422
Comments
There is a an open PR here: bioconda/bioconda-recipes#39340, you are welcome to make the necessary changes and I can review. Note, we are moving away from using bioconda due to the lack of control over the package update and release process: principally anyone being able to come along and change the package. See bioconda/bioconda-actions#19 (comment) |
Conda/bioconda is more or less the defacto standard for a lot of biologists doing bioinformatics. So although I understand ONT's reasons for switching, I am not really convinced that it's a good thing for ONT customers. Could you at least use a consistent method for installing ONT tools? An other thing. Conda manages dependencies very well. Using your suggested virtualenv method, installation crashed a couple of times due to dependencies(libbz2-dev etc.), which are just listed under build from source. |
I stated that we are moving away from bioconda, not conda. Within the current bioconda build and review system, there are no guarantees that the software is that which Oxford Nanopore Technologies provides. Whilst we embrace the open source ethos, we must also make efforts to ensure that our software reamins supportable. I'm not sure what you mean by your second point; the most noteworthy parts of The binary pacakages (wheels) available on PyPI do not depend on external libraries being present. The fact that the installation was looking for the bzip2 development package suggests to me that you have triggered installation from the source distribution. This would lead to code compilation, hence needing the development package. I would have to know more about your system to understand why this might have occurred; ordinarily it should not since we have a wide selection of binary packages available. |
Ah, I didn't realize different conda channels had different rules about things like e.g.
If not moving away from conda, are the medaka team using/planning to use a different channel? Something capable of being pinned during |
I did exactly what was described on the medaka github page:
Lots of errors, some as described above. I never got medaka running. Also deactivating conda wouldn't help, pip installation always crashed, so I gave up at a certain point. |
As stated, I would need to understand more about your system to know why the wheels on PyPI were not being used during installation. On a vanilla Ubuntu 20.04 system (the official docker image from dockerhub) the following is sufficient:
Note the first and second lines here shouldn't be required typically on a system, we're just bootstrapping the Python install in the docker container. The 5th line here is required to update pip; this step is crucial, without it If I may extrapolate from this, I would guess the issue you have is the |
Admittedly my mistake, i lost track of the pip installs in different environments and the pip of the OS was indeed not updated. Thanks a lot! |
I don't know how to identify who facilitated it, but last week's update (1.8.0) is already on Bioconda. Given that, I hope no one minds me closing this. Thanks to everyone who helped, and whomever wrangled medaka onto bioconda in particular! |
Can I pester the maintainer on bioconda to release the newest Medaka there? (Is that pending resolution of the current handful of issue requests?)
Is your feature request related to a problem? Please describe.
DragonFlye is an awesome and easy one-stop solution to include Medaka and many other tools, but will only incorporate conda releases and currently relies on a quite dated Medaka. I'm hoping an updated bioconda release of Medaka enables usage of the newest LR polishing as part of the DragonFlye (and hopefully newer Bactopia) pipelines. I tried quickly pinning v1.7.2 but couldn't get it to work, and would like the newest version pinned before troubling the DragonFlye author for further help.
Describe the solution you'd like
Anything to improve chances of no longer needing hybrid bacterial assemblies :'D
More specifically I'd like this link to take everyone to a page that says "bioconda / packages / medaka 1.7.3" or newer up top.
Additional context
Related to: rpetit3/dragonflye#17
ONT bioinformatics people might be interested to see that even Wick/Holt's freshest paper seems to draw conclusions based on chemistry 14 ligation kit accuracy, seemingly without having the opportunity to try incorporating the brand new chemistry 14 transposase kit. Would be amazing to see if we can get those small plasmids and improved R10.4.1 post-assembly accuracy using chemistry 14 transposase indexing and no SR polishing. Medaka would have to be a major part of accomplishing that. The ability to incorporate the newest medaka into dragonFlye by default would expedite the ability of non-bioinformaticians like me to have a go :)
The text was updated successfully, but these errors were encountered: