Private/marios/smb1 next #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 12, 2023 19:19
automatic changes using clang-format to: * keep code around ~80 columns * fix some odd argument indentations * remove double spaces Not all changes were picked as the clang-formatted code is not always more readable. This makes the code a bit more coherent and brings it closer to the Linux kernel code style. while here fix some typos. Signed-off-by: Marios Makassikis <[email protected]>
SMB_COM_PROCESS_EXIT is a deprecated command from earlier CIFS dialects that is really only used by smbtorture tests. Signed-off-by: Marios Makassikis <[email protected]>
Fixes a memory leak in smb_get_name() and a double-free in smb_get_dir_name() if a name with an invalid character was passed in. Signed-off-by: Marios Makassikis <[email protected]>
Signed-off-by: Marios Makassikis <[email protected]>
[MS-CIFS] 3.3.5.33
* If EchoCount is zero, a response MUST NOT be sent
* The server MAY enforce any nonzero limit in the number of responses
that it returns
Signed-off-by: Marios Makassikis <[email protected]>
Signed-off-by: Marios Makassikis <[email protected]>
SMB_COM_QUERY_INFORMATION_DISK is marked as deprecated, but smbclient will use it if SMB Trans2/QUERY_FS_INFO fails. ksmbd will disconnect the client because the command is not implemented. The response to this command contains the same information as QUERY_FS_SIZE_INFO/QUERY_FS_FULL_SIZE_INFO infolevels. The difference is that the fields are u16, so they may not be large enough. Values are adjusted so that the client can determine free and used space in bytes (which is what it really cares about). Signed-off-by: Marios Makassikis <[email protected]>
|
Applied! Thansk for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes from testing with smbtorture