ksmbd: not allow to open file if delete pending or delelete on close …

…bit is set Cthon test fail with the following error. check for proper open/unlink operation nfsjunk files before unlink: -rwxr-xr-x 1 root root 0 9월 25 11:03 ./nfs2y8Jm9 ./nfs2y8Jm9 open; unlink ret = 0 nfsjunk files after unlink: -rwxr-xr-x 1 root root 0 9월 25 11:03 ./nfs2y8Jm9 data compare ok Error: second unlink succeeded!?? nfsjunk files after close: ls: cannot access './nfs2y8Jm9': No such file or directory special tests failed Cthon expect to second unlink failure when file is already unlinked. ksmbd can not allow to open file if flags of ksmbd inode is set with S_DEL_PENDING or S_DEL_ON_CLS. Signed-off-by: Namjae Jeon <[email protected]>
namjaejeon · Sep 25, 2023 · 7e2b571 · 7e2b571
1 parent 332f4ca
commit 7e2b571
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/vfs_cache.c b/vfs_cache.c
@@ -637,6 +637,11 @@ struct ksmbd_file *ksmbd_open_fd(struct ksmbd_work *work, struct file *filp)
 		goto err_out;
 	}
 
+	if (fp->f_ci->m_flags & (S_DEL_PENDING | S_DEL_ON_CLS)) {
+		ret = -ENOENT;
+		goto err_out;
+	}
+
 	ret = __open_id(&work->sess->file_table, fp, OPEN_ID_TYPE_VOLATILE_ID);
 	if (ret) {
 		ksmbd_inode_put(fp->f_ci);